lizhimins commented on PR #5297: URL: https://github.com/apache/rocketmq-dashboard/pull/5297#issuecomment-6446481169
Merged as part of #5649 - squashed into `rocketmq-studio` as `aaf1d367c`. Your change here (walking the cause chain for the `uk_instance_name` unique key so a concurrent create that loses the race answers with the same 400 as the sequential path, instead of a bare 500. Landing it needed one substantive addition: #7353 made `nameserverId` mandatory on the APACHE create path after you opened the PR, so the test fixture now supplies it. We also gave the new test method the repository's `Test` suffix and moved the `java.sql.SQLException` import into the `java.*` group.) is included. We grouped 3 of your related fixes into a single commit so the trunk history stays reviewable; the other PR in the group is closed with the same note. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change - the combined branch runs 4161 backend tests and 2019 frontend tests green, with the catalog, license, type-check and lint gates clean. Where the note above says "we", that part was added while landing the batch; the rest is yours unchanged. Thanks for the carefully evidenced patches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
