lizhimins commented on PR #6668:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/6668#issuecomment-6441472938

   Merged as part of #6851 - squashed into `rocketmq-studio` as `da2513c9f`.
   
   Your change here (writing `gmt_create` and `gmt_modified` explicitly from a 
single `LocalDateTime.now()` instead of relying on database defaults. We 
replayed the two INSERTs against the shape #7353 gave them (with `domain` and 
the renamed `target`), moved the `java.time` import into the `java.*` block, 
and strengthened the two tests to assert the columns are equal and to bound the 
stamp against the JVM clock - the previous assertions only proved the INSERT 
did not throw.) is included.
   
   We grouped 11 of your related fixes into a single commit so the trunk 
history stays reviewable; the other PRs in the group are closed with the same 
note. Everything was cherry-picked onto the current baseline with you kept as 
the author, and your tests came along with the change - the combined branch 
runs 4143 backend tests and 2009 frontend tests green, with the catalog, 
license and lint gates clean.
   
   Where the note above says "we", that part was added while landing the batch; 
the rest is yours unchanged. Thanks for the consistently well-tested patches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to