lizhimins commented on PR #7000: URL: https://github.com/apache/rocketmq-dashboard/pull/7000#issuecomment-6448367611
Merged as part of #7207 - squashed into `rocketmq-studio` as `fe44f3a47`. Your change here (swallowing a stop-request failure once the run it belonged to has already ended, and clearing `stopRequested` before that early return so the composer does not stay stuck in the stopping state. Both points the review raised are in: the flag is reset ahead of the guard, and there is now an assertion that the state is not stuck after `run_finished`.) is included. We grouped 2 of your related fixes into a single commit so the trunk history stays reviewable; the other PR in the group is closed with the same note. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change. The combined branch was verified against the full backend and frontend suites, the license gate, the type check and lint before merging. Thanks for the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
