lizhimins commented on PR #7203: URL: https://github.com/apache/rocketmq-dashboard/pull/7203#issuecomment-6448428813
Merged as part of #7188 - squashed into `rocketmq-studio` as `7f2dfd3ed`. Your change here (counting only the clients that actually have lite topics under the parent topic in buildSummary, so the consumer count stops including clients connected to the group but unrelated to this parent) is included. Resolving the client once also let the separate clientLastAccess lookup go away, since the same record carries lastAccessTime. We grouped 2 of your related fixes into a single commit so the trunk history stays reviewable. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change - removing the lite-topic filter fails listLiteTopicsShouldCountOnlyClientsSubscribedToTheParentTopicTest, so the behaviour is pinned. Note that #7344 is still open and adds a test at the same point in RocketMQLiteTopicProviderTest, so it will need a rebase onto this. Thanks for the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
