lizhimins commented on PR #6210:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/6210#issuecomment-6448369410

   Merged as part of #6312 - squashed into `rocketmq-studio` as `66519d03d`.
   
   Your change here (aligning `deploy/mysql/upgrade-cloud-vendor.sql` with 
`schema.sql` - a bigint auto-increment primary key and the `gmt_create` / 
`gmt_modified` columns instead of `id VARCHAR(64)` with `created_at` / 
`updated_at`, and the matching bigint for `credential_id`. A database built by 
the upgrade script did not match one built from schema.sql, and 
`CloudCredentialSchemaMigration` only adds indexes and foreign keys, so nothing 
corrected the columns afterwards.) is included.
   
   We grouped 2 of your related fixes into a single commit so the trunk history 
stays reviewable; the other PR in the group is closed with the same note. 
Everything was cherry-picked onto the current baseline with you kept as the 
author, and your tests came along with the change. The combined branch was 
verified against the full backend and frontend suites, the license gate, the 
type check and lint before merging.
   
   Thanks for the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to