Ajax-1 commented on PR #11499: URL: https://github.com/apache/rocketmq/pull/11499#issuecomment-6502365199
Hi, a note for reviewers: #11498 was closed by the reporter, but as far as I can tell the issue is still present on `develop` — `checkAndReviseMetrics()` still passes the `Long.MAX_VALUE` sentinel from `TimerWheel.checkPhyPos` into the TimerLog lookup. This PR fixes it and adds unit tests for the empty-wheel and valid-slot cases. @StiffCoconut, if it was closed by mistake, would you mind reopening it? Otherwise I'm happy to adjust this PR however the committers prefer. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
