caigy commented on code in PR #5508:
URL: https://github.com/apache/rocketmq/pull/5508#discussion_r1019779412
##########
common/src/main/java/org/apache/rocketmq/common/attribute/AttributeParser.java:
##########
@@ -16,38 +16,44 @@
*/
package org.apache.rocketmq.common.attribute;
-import com.google.common.base.Joiner;
import com.google.common.base.Strings;
-
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
public class AttributeParser {
+
+ public static final String COMMA = ",";
+
+ public static final String EQUAL_SIGN = "=";
+
+ public static final String PLUS_SIGN = "+";
+
+ private static final String MINUS_SIGN = "-";
Review Comment:
Pls use more descriptive names, like 'ATTR_ARRAY_SEPARATOR'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
