yandongxiao opened a new pull request, #959:
URL: https://github.com/apache/rocketmq-client-go/pull/959

   ## What is the purpose of the change
   
   fix some errors reported by go vet
   
   ## Brief changelog
   
   go vet ./...
   ```
   # github.com/apache/rocketmq-client-go/v2/producer
   producer/producer.go:280:23: literal copies lock value from *msg: 
github.com/apache/rocketmq-client-go/v2/primitive.Message contains sync.RWMutex
   # github.com/apache/rocketmq-client-go/v2/internal/remote
   internal/remote/codec.go:136:33: method WriteTo(w io.Writer) error should 
have signature WriteTo(io.Writer) (int64, error)
   internal/remote/remote_client_test.go:164:4: call to (*T).Fatalf from a 
non-test goroutine
   internal/remote/remote_client_test.go:340:4: call to (*T).Fatalf from a 
non-test goroutine
   # github.com/apache/rocketmq-client-go/v2/consumer
   consumer/lock.go:34:10: fetchLock passes lock by value: 
github.com/apache/rocketmq-client-go/v2/consumer.QueueLock contains sync.Map 
contains sync.Mutex
   # github.com/apache/rocketmq-client-go/v2/internal
   internal/trace.go:246:2: the cancel function is not used on all paths 
(possible context leak)
   internal/trace.go:285:3: this return statement may be reached without using 
the cancel var defined on line 246
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to