leizhiyuan commented on PR #1472: URL: https://github.com/apache/rocketmq-clients/pull/1472#issuecomment-6598130337
Thanks for the careful review! All four points are addressed in `0f952041` and `6f05a677`: 1. **Route refresh.** Reverted (`0f952041`); it stays at 10s. I agree the two goals are independent: commit 5 already logs an unchanged route at DEBUG, so 10s adds no INFO lines. The restored comment now says so, and `settings_sync_and_stream_check_intervals` pins the 10s. 2. **Start failure.** The start paths now shut the client down like Java's `#startUp`, so the scheduler and the sessions no longer outlive a failed `start()`. A `ClientIsNotRunning` from the cleanup (a start rejected before `Client::start`, e.g. an empty consumer group) is tolerated; any other cleanup failure is logged. While testing this I found that `Client::shutdown_ref` returned early when the termination notice failed, before releasing the scheduler and the sessions. It now logs that failure and still releases everything, like `ClientImpl#shutDown`. Covered by `*_start_failure_shuts_down_client`, `*_before_client_start_tolerates_cleanup` and `shutdown_releases_resources_when_notify_termination_fails`; the cleanup tests fail without the change. 3. **`clientType`.** `apply_settings` now takes the client type, as `simple_consumer` does, so a lite consumer reports `LITE_PUSH_CONSUMER` (`test_settings_mismatch_reports_the_client_type`). 4. **Lite cleanup.** The four `let _ = self.shutdown().await;` are replaced by a shared helper that logs a failed cleanup, `Failed to shutdown the rocketmq <type> after a failed start, ...`, and stays silent on `ClientIsNotRunning`, which is expected when the inner consumer already shut its client down. Thanks also for the precision on #5. On the non-blocking items, I'd rather keep them out of this PR as you suggested. I listed the assignment-scan and session-cleanup periods under "Differences left on purpose" for now, and I'm happy to align them, together with `MissedTickBehavior::Delay` on the timers, in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
