ShadowySpirits commented on code in PR #5514:
URL: https://github.com/apache/rocketmq/pull/5514#discussion_r1020885830
##########
proxy/src/main/java/org/apache/rocketmq/proxy/metrics/ProxyMetricsManager.java:
##########
@@ -69,6 +69,9 @@ public class ProxyMetricsManager implements StartAndShutdown {
public static ObservableLongGauge proxyUp = null;
public static void initLocalMode(BrokerMetricsManager
brokerMetricsManager, ProxyConfig proxyConfig) {
+ if (proxyConfig.getMetricsExporterType() !=
BrokerConfig.MetricsExporterType.DISABLE) {
Review Comment:
We should skip init process when metrics exporter is disable and not the
other way around.
##########
proxy/src/main/java/org/apache/rocketmq/proxy/metrics/ProxyMetricsManager.java:
##########
@@ -69,6 +69,9 @@ public class ProxyMetricsManager implements StartAndShutdown {
public static ObservableLongGauge proxyUp = null;
public static void initLocalMode(BrokerMetricsManager
brokerMetricsManager, ProxyConfig proxyConfig) {
+ if (proxyConfig.getMetricsExporterType() !=
BrokerConfig.MetricsExporterType.DISABLE) {
Review Comment:
This check should also be added in ProxyMetricsManager#start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
