aaron-ai commented on code in PR #5540:
URL: https://github.com/apache/rocketmq/pull/5540#discussion_r1028724454
##########
acl/pom.xml:
##########
@@ -43,6 +39,14 @@
<groupId>${project.groupId}</groupId>
<artifactId>rocketmq-srvutil</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.github.aliyun-mq</groupId>
+ <artifactId>rocketmq-slf4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.github.aliyun-mq</groupId>
+ <artifactId>rocketmq-logback-classic</artifactId>
+ </dependency>
Review Comment:
@RongtongJin Actually a more neutral repo(e.g. some other repos which belong
to apache rocketmq) is considered, but we want to avoid the redundant polling
procedure at present, because we'd better to keep up to date with the original
version, current polling procedure is uncesscary.
On the other hand, I think current group id is ok because the License is
more important, or we could refer to the dependency of fastjson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
