odbozhou commented on code in PR #391:
URL: https://github.com/apache/rocketmq-connect/pull/391#discussion_r1046633929


##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerSinkTask.java:
##########
@@ -558,8 +558,11 @@ private ConnectRecord convertMessages(MessageExt message) {
         }
 
         // add extension
-        addExtension(properties, record);
-        return record;
+        addExtension(properties, transformedRecord);
+
+        // add msgId to extension
+        transformedRecord.addExtension("MQ-SYS-MSG_ID", message.getMsgId());

Review Comment:
   Why increase MQ-SYS-MSG_ID alone? If it is necessary to increase whether it 
can be put in the addExtension method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to