mxsm commented on PR #5689: URL: https://github.com/apache/rocketmq/pull/5689#issuecomment-1348487612
> > > No, we don't need to add configuration file into the distribution directory because it has been included by the generated jar. > > > > > > @aaron-ai IMO, it has been included by the generated jar, but if O&M wants to change the log level, they can't. So I think should add those files into the distribution directory. It is convenient to modify the log level and log output position dynamically.I think these files should be included for binary packages. > > Keeping a copy is not a good practice to maintain the configuration file, consider to copy it in compile stage if you really want to keep a copy in the distribution directory. That's a good idea, I will try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
