odbozhou commented on code in PR #386:
URL: https://github.com/apache/rocketmq-connect/pull/386#discussion_r1050326089
##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/memory/MemoryConfigManagementServiceImpl.java:
##########
@@ -134,6 +134,38 @@ public void deleteConnectorConfig(String connectorName) {
triggerListener();
}
+ @Override
+ public void restartConnector(String connectorName) {
Review Comment:
Because connect is distributed, there are generally multiple worker nodes,
so connectors and tasks may run on other nodes, so the worker node that
receives the restart request may not run the connector or task that needs to be
restarted, so the task or connector When restarting, the configuration or
status needs to be sent to the config topic, and each worker node receives the
information in the config topic, in
org.apache.rocketmq.connect.runtime.service.ConfigManagementServiceImpl.ConfigChangeCallback#onCompletion
Handle the restart operation.
##########
rocketmq-connect-runtime/src/test/java/org/apache/rocketmq/connect/runtime/controller/distributed/TestConfigManagementService.java:
##########
@@ -58,6 +58,16 @@ public void deleteConnectorConfig(String connectorName) {
}
+ @Override
+ public void restartConnector(String connectorName) {
Review Comment:
Can you provide some test cases to verify this new feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
