ShadowySpirits commented on issue #5720: URL: https://github.com/apache/rocketmq/issues/5720#issuecomment-1356122426
> > the possibility to use a different clock source > > then `now` should be wrapped as a static method just as guava did. Guava wraps a class method into a static method which is more reasonable. > > as the possiblity to use a different clock source,is there any neccessary or just a over-design? I'm just making a guess about the current design. IMO, It is inappropriate to use `System.currentTimeMillis()` in TimerMessageStore. If we can use the mock time source, it would be of great help to our test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
