aaron-ai commented on code in PR #324:
URL: https://github.com/apache/rocketmq-clients/pull/324#discussion_r1057029825
##########
csharp/rocketmq-client-csharp/Producer.cs:
##########
@@ -128,22 +128,18 @@ public async Task<SendReceipt> Send(Message message)
{
ResourceNamespace = resourceNamespace(),
Name = message.Topic
- }
+ },
+ UserProperties = { message.UserProperties },
+ SystemProperties = new rmq::SystemProperties
+ {
+ MessageId = message.MessageId,
+ MessageType = rmq::MessageType.Normal,
+ Tag = message.Tag ?? string.Empty,
Review Comment:
If message's tag is not set, we should not set it as an empty string.
As you could see from
https://github.com/apache/rocketmq-apis/blob/e83a1bceacbef5be465a459965d8edee59cad0c2/apache/rocketmq/v2/definition.proto#L200,
the message tag field is optional, which means that it should be absent if
message tag is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
