This is an automated email from the ASF dual-hosted git repository. hzh0425 pushed a commit to branch dledger-controller-snapshot in repository https://gitbox.apache.org/repos/asf/rocketmq.git
commit 4e9aee62581f1c34abd305f95676cc92be6aac52 Author: hzh0425 <[email protected]> AuthorDate: Mon Jan 2 19:37:07 2023 +0800 Polish ReplicasInfoManagerTest - make ReplicasInfoManagerTest.registerNewBroker return void --- .../impl/controller/impl/manager/ReplicasInfoManagerTest.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/controller/src/test/java/org/apache/rocketmq/controller/impl/controller/impl/manager/ReplicasInfoManagerTest.java b/controller/src/test/java/org/apache/rocketmq/controller/impl/controller/impl/manager/ReplicasInfoManagerTest.java index 40862544c..b5bbd2027 100644 --- a/controller/src/test/java/org/apache/rocketmq/controller/impl/controller/impl/manager/ReplicasInfoManagerTest.java +++ b/controller/src/test/java/org/apache/rocketmq/controller/impl/controller/impl/manager/ReplicasInfoManagerTest.java @@ -74,8 +74,8 @@ public class ReplicasInfoManagerTest { this.heartbeatManager = null; } - public boolean registerNewBroker(String clusterName, String brokerName, String brokerAddress, - boolean isFirstRegisteredBroker) { + public void registerNewBroker(String clusterName, String brokerName, String brokerAddress, + boolean isFirstRegisteredBroker) { // Register new broker final RegisterBrokerToControllerRequestHeader registerRequest = new RegisterBrokerToControllerRequestHeader(clusterName, brokerName, brokerAddress); @@ -91,7 +91,6 @@ public class ReplicasInfoManagerTest { final RegisterBrokerToControllerResponseHeader response = registerResult.getResponse(); assertTrue(response.getBrokerId() > 0); } - return true; } @Test @@ -126,7 +125,6 @@ public class ReplicasInfoManagerTest { apply(result.getEvents()); final ControllerResult<GetReplicaInfoResponseHeader> resp = this.replicasInfoManager.getReplicaInfo(new GetReplicaInfoRequestHeader(brokerName)); - final GetReplicaInfoResponseHeader replicaInfo = resp.getResponse(); final SyncStateSet syncStateSet = RemotingSerializable.decode(resp.getBody(), SyncStateSet.class); assertArrayEquals(syncStateSet.getSyncStateSet().toArray(), newSyncStateSet.toArray()); @@ -251,10 +249,6 @@ public class ReplicasInfoManagerTest { assertFalse(response.getNewMasterAddress().isEmpty()); assertNotEquals(response.getNewMasterAddress(), "127.0.0.1:9000"); - final Set<String> brokerSet = new HashSet<>(); - brokerSet.add("127.0.0.1:9000"); - brokerSet.add("127.0.0.1:9001"); - brokerSet.add("127.0.0.1:9002"); final ElectMasterRequestHeader assignRequest = new ElectMasterRequestHeader("cluster1", "broker1", "127.0.0.1:9000"); final ControllerResult<ElectMasterResponseHeader> cResult1 = this.replicasInfoManager.electMaster(assignRequest, new DefaultElectPolicy((clusterName, brokerAddress) -> brokerAddress.contains("127.0.0.1:9000"), null)); @@ -274,7 +268,6 @@ public class ReplicasInfoManagerTest { assertEquals(response.getMasterEpoch(), 2); assertFalse(response.getNewMasterAddress().isEmpty()); assertNotEquals(response.getNewMasterAddress(), "127.0.0.1:9000"); - } @Test
