guyinyou commented on code in PR #235:
URL: https://github.com/apache/rocketmq-clients/pull/235#discussion_r971487631
##########
golang/client_manager.go:
##########
@@ -90,13 +90,14 @@ type ClientManagerRegistry interface {
}
type clientManagerRegistry struct {
- clientIds map[string]bool
- clientIdsLock sync.Mutex
- singletonClientManager ClientManager
+ clientIds map[string]bool
Review Comment:
After this pr, "clientIds" is useless, recommended to delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
