ShadowySpirits commented on code in PR #5824:
URL: https://github.com/apache/rocketmq/pull/5824#discussion_r1061513968
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -1960,11 +1960,20 @@ public RemotingCommand deleteExpiredCommitLog() {
}
public RemotingCommand cleanUnusedTopic() {
- LOGGER.warn("invoke cleanUnusedTopic start.");
+ LOGGER.info("AdminBrokerProcessor#cleanUnusedTopic: start.");
final RemotingCommand response =
RemotingCommand.createResponseCommand(null);
-
brokerController.getMessageStore().cleanUnusedTopic(brokerController.getTopicConfigManager().getTopicConfigTable().keySet());
- LOGGER.warn("invoke cleanUnusedTopic end.");
- response.setCode(ResponseCode.SUCCESS);
+ Set<String> topicManagerTopics = Sets.newHashSet(
+
brokerController.getTopicConfigManager().getTopicConfigTable().keySet());
+ int responseCode = ResponseCode.SUCCESS;
+ if (this.brokerController.getMessageStore() instanceof
DefaultMessageStore) {
Review Comment:
Why should we add this restriction？ IMO, there is no need to care about the
underlying implementation outside the store module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
