ShadowySpirits commented on code in PR #5826:
URL: https://github.com/apache/rocketmq/pull/5826#discussion_r1062137437
##########
common/src/main/java/org/apache/rocketmq/common/message/Message.java:
##########
@@ -210,7 +210,7 @@ public String toString() {
"topic='" + topic + '\'' +
", flag=" + flag +
", properties=" + properties +
- ", body=" + Arrays.toString(body) +
+ ", body=" + (body != null ? new String(body,
StandardCharsets.UTF_8) : "") +
Review Comment:
> > The message body may be very large and compressed or serialized. It's
better not to print the message body in `toString` function.
>
> Wasn't it also printed before this modification? Do you mean to delete
this directly
Maybe print body size instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
