lollipopjin commented on code in PR #5840:
URL: https://github.com/apache/rocketmq/pull/5840#discussion_r1064339915
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -1600,13 +1633,29 @@ private long nextOffsetCorrection(long oldOffset, long
newOffset) {
return nextOffset;
}
- private boolean checkInDiskByCommitOffset(long offsetPy, long maxOffsetPy)
{
+ private boolean estimateInMemByCommitOffset(long offsetPy, long
maxOffsetPy) {
long memory = (long) (StoreUtil.TOTAL_PHYSICAL_MEMORY_SIZE *
(this.messageStoreConfig.getAccessMessageInMemoryMaxRatio() / 100.0));
- return (maxOffsetPy - offsetPy) > memory;
+ return (maxOffsetPy - offsetPy) < memory;
Review Comment:
Here should use <=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
