xdkxlk commented on code in PR #5870:
URL: https://github.com/apache/rocketmq/pull/5870#discussion_r1068055068
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -695,16 +695,13 @@ private SendResult sendDefaultImpl(
if (sendResult != null) {
return sendResult;
}
+ StringBuilder info = new StringBuilder(300);
+ info.append("Send [").append(times).append("] times, still failed,
cost [")
+ .append(System.currentTimeMillis() -
beginTimestampFirst).append("]ms, Topic: ").append(msg.getTopic())
+ .append(", BrokersSent: ").append(Arrays.toString(brokersSent))
+ .append(FAQUrl.suggestTodo(FAQUrl.SEND_MSG_FAILED));
Review Comment:
Use MoreObjects.toStringHelper of guava or ToStringBuilder of commons-lang
is more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
