lollipopjin commented on code in PR #5892: URL: https://github.com/apache/rocketmq/pull/5892#discussion_r1071816985
########## tieredstore/src/main/java/org/apache/rocketmq/store/tiered/metrics/TieredStoreMetricsManager.java: ########## @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.rocketmq.store.tiered.metrics; + +import com.github.benmanes.caffeine.cache.Policy; +import io.opentelemetry.api.common.Attributes; +import io.opentelemetry.api.common.AttributesBuilder; +import io.opentelemetry.api.metrics.LongCounter; +import io.opentelemetry.api.metrics.LongHistogram; +import io.opentelemetry.api.metrics.Meter; +import io.opentelemetry.api.metrics.ObservableLongGauge; +import io.opentelemetry.sdk.metrics.Aggregation; +import io.opentelemetry.sdk.metrics.InstrumentSelector; +import io.opentelemetry.sdk.metrics.InstrumentType; +import io.opentelemetry.sdk.metrics.View; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.function.Supplier; +import org.apache.rocketmq.common.Pair; +import org.apache.rocketmq.common.message.MessageQueue; +import org.apache.rocketmq.common.metrics.NopLongCounter; +import org.apache.rocketmq.common.metrics.NopLongHistogram; +import org.apache.rocketmq.common.metrics.NopObservableLongGauge; +import org.apache.rocketmq.logging.org.slf4j.Logger; +import org.apache.rocketmq.logging.org.slf4j.LoggerFactory; +import org.apache.rocketmq.store.MessageStore; +import org.apache.rocketmq.store.tiered.TieredMessageFetcher; +import org.apache.rocketmq.store.tiered.common.MessageCacheKey; +import org.apache.rocketmq.store.tiered.common.SelectMappedBufferResultWrapper; +import org.apache.rocketmq.store.tiered.common.TieredMessageStoreConfig; +import org.apache.rocketmq.store.tiered.container.TieredContainerManager; +import org.apache.rocketmq.store.tiered.container.TieredFileSegment; +import org.apache.rocketmq.store.tiered.container.TieredMessageQueueContainer; +import org.apache.rocketmq.store.tiered.metadata.TieredMetadataStore; +import org.apache.rocketmq.store.tiered.util.TieredStoreUtil; + +import static org.apache.rocketmq.store.metrics.DefaultStoreMetricsConstant.GAUGE_STORAGE_SIZE; +import static org.apache.rocketmq.store.metrics.DefaultStoreMetricsConstant.LABEL_STORAGE_MEDIUM; +import static org.apache.rocketmq.store.metrics.DefaultStoreMetricsConstant.LABEL_STORAGE_TYPE; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.COUNTER_CACHE_ACCESS; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.COUNTER_CACHE_HIT; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.COUNTER_GET_MESSAGE_FALLBACK_TOTAL; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.COUNTER_MESSAGES_DISPATCH_TOTAL; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.COUNTER_MESSAGES_OUT_TOTAL; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.GAUGE_CACHE_BYTES; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.GAUGE_CACHE_COUNT; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.GAUGE_DISPATCH_BEHIND; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.GAUGE_DISPATCH_LATENCY; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.GAUGE_STORAGE_MESSAGE_RESERVE_TIME; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.HISTOGRAM_API_LATENCY; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.HISTOGRAM_DOWNLOAD_BYTES; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.HISTOGRAM_PROVIDER_RPC_LATENCY; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.HISTOGRAM_UPLOAD_BYTES; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.LABEL_FILE_TYPE; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.LABEL_QUEUE; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.LABEL_TOPIC; +import static org.apache.rocketmq.store.tiered.metrics.TieredStoreMetricsConstant.STORAGE_MEDIUM_BLOB; + +public class TieredStoreMetricsManager { + private static final Logger logger = LoggerFactory.getLogger(TieredStoreUtil.TIERED_STORE_LOGGER_NAME); + public static Supplier<AttributesBuilder> attributesBuilderSupplier; + + public static LongHistogram apiLatency = new NopLongHistogram(); + + // tiered store provider metrics + public static LongHistogram providerRpcLatency = new NopLongHistogram(); + public static LongHistogram uploadBytes = new NopLongHistogram(); + public static LongHistogram downloadBytes = new NopLongHistogram(); + + public static ObservableLongGauge dispatchBehind = new NopObservableLongGauge(); + public static ObservableLongGauge dispatchLatency = new NopObservableLongGauge(); + public static LongCounter messagesDispatchTotal = new NopLongCounter(); + public static LongCounter messagesOutTotal = new NopLongCounter(); + public static LongCounter fallbackTotal = new NopLongCounter(); + + public static ObservableLongGauge cacheCount = new NopObservableLongGauge(); + public static ObservableLongGauge cacheBytes = new NopObservableLongGauge(); + public static LongCounter cacheAccess = new NopLongCounter(); + public static LongCounter cacheHit = new NopLongCounter(); + + public static ObservableLongGauge storageSize = new NopObservableLongGauge(); + public static ObservableLongGauge storageMessageReserveTime = new NopObservableLongGauge(); + + public static List<Pair<InstrumentSelector, View>> getMetricsView() { + ArrayList<Pair<InstrumentSelector, View>> res = new ArrayList<>(); + + InstrumentSelector providerRpcLatencySelector = InstrumentSelector.builder() + .setType(InstrumentType.HISTOGRAM) + .setName(HISTOGRAM_PROVIDER_RPC_LATENCY) + .build(); + + InstrumentSelector rpcLatencySelector = InstrumentSelector.builder() + .setType(InstrumentType.HISTOGRAM) + .setName(HISTOGRAM_API_LATENCY) + .build(); + + View rpcLatencyView = View.builder() + .setAggregation(Aggregation.explicitBucketHistogram(Arrays.asList(1d, 10d, 100d, 200d, 400d, 600d, 800d, 1d * 1000, 1d * 1500, 1d * 3000))) + .setDescription("tiered_store_rpc_latency_view") + .build(); + + InstrumentSelector uploadBufferSizeSelector = InstrumentSelector.builder() + .setType(InstrumentType.HISTOGRAM) + .setName(HISTOGRAM_UPLOAD_BYTES) + .build(); + + InstrumentSelector downloadBufferSizeSelector = InstrumentSelector.builder() + .setType(InstrumentType.HISTOGRAM) + .setName(HISTOGRAM_DOWNLOAD_BYTES) + .build(); + + View bufferSizeView = View.builder() + .setAggregation(Aggregation.explicitBucketHistogram(Arrays.asList(1024d, 10d * 1024, 100d * 1024, 1024d * 1024, 10d * 1024 * 1024, 32d * 1024 * 1024, 50d * 1024 * 1024, 100d * 1024 * 1024))) Review Comment: Here can we use private static final double KB = 1024d; 1 * KB, 10 * KB .... to improve the readability? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
