This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 7cbdad378 [ISSUE #5885] Fix FAQurl's class FAQ url incorrect (#5886)
7cbdad378 is described below

commit 7cbdad378e964e882d8b83afc718ffb34641915e
Author: mxsm <[email protected]>
AuthorDate: Tue Jan 17 16:05:47 2023 +0800

    [ISSUE #5885] Fix FAQurl's class FAQ url incorrect (#5886)
---
 .../org/apache/rocketmq/common/help/FAQUrl.java    | 33 +++++++++++-----------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/common/src/main/java/org/apache/rocketmq/common/help/FAQUrl.java 
b/common/src/main/java/org/apache/rocketmq/common/help/FAQUrl.java
index 5d950bebf..cec9fce79 100644
--- a/common/src/main/java/org/apache/rocketmq/common/help/FAQUrl.java
+++ b/common/src/main/java/org/apache/rocketmq/common/help/FAQUrl.java
@@ -19,50 +19,51 @@ package org.apache.rocketmq.common.help;
 public class FAQUrl {
 
     public static final String APPLY_TOPIC_URL =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String NAME_SERVER_ADDR_NOT_EXIST_URL =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String GROUP_NAME_DUPLICATE_URL =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String CLIENT_PARAMETER_CHECK_URL =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String SUBSCRIPTION_GROUP_NOT_EXIST =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String CLIENT_SERVICE_NOT_OK =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     // FAQ: No route info of this topic, TopicABC
     public static final String NO_TOPIC_ROUTE_INFO =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String LOAD_JSON_EXCEPTION =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String SAME_GROUP_DIFFERENT_TOPIC =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String MQLIST_NOT_EXIST =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String UNEXPECTED_EXCEPTION_URL =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String SEND_MSG_FAILED =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     public static final String UNKNOWN_HOST_EXCEPTION =
-        "http://rocketmq.apache.org/docs/faq/";;
+        "https://rocketmq.apache.org/docs/bestPractice/22FAQ";;
 
     private static final String TIP_STRING_BEGIN = "\nSee ";
     private static final String TIP_STRING_END = " for further details.";
+    private static final String MORE_INFORMATION = "For more information, 
please visit the url, ";
 
     public static String suggestTodo(final String url) {
-        StringBuilder sb = new StringBuilder();
+        StringBuilder sb = new StringBuilder(TIP_STRING_BEGIN.length() + 
url.length() + TIP_STRING_END.length());
         sb.append(TIP_STRING_BEGIN);
         sb.append(url);
         sb.append(TIP_STRING_END);
@@ -73,10 +74,10 @@ public class FAQUrl {
         if (errorMessage != null) {
             int index = errorMessage.indexOf(TIP_STRING_BEGIN);
             if (-1 == index) {
-                StringBuilder sb = new StringBuilder();
+                StringBuilder sb = new StringBuilder(errorMessage.length() + 
UNEXPECTED_EXCEPTION_URL.length() + MORE_INFORMATION.length() + 1);
                 sb.append(errorMessage);
                 sb.append("\n");
-                sb.append("For more information, please visit the url, ");
+                sb.append(MORE_INFORMATION);
                 sb.append(UNEXPECTED_EXCEPTION_URL);
                 return sb.toString();
             }

Reply via email to