[rocketmq] branch develop updated: [ISSUE #5859]Optimize String#format in DefaultMQProducerImpl (#5870)

[jinrongtong]

This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new c82ab449a [ISSUE #5859]Optimize String#format in DefaultMQProducerImpl 
(#5870)
c82ab449a is described below

commit c82ab449a423e188f3e5530e51b02b86942cee0e
Author: mxsm <ljbm...@gmail.com>
AuthorDate: Tue Jan 17 16:47:17 2023 +0800

    [ISSUE #5859]Optimize String#format in DefaultMQProducerImpl (#5870)
    
    * [ISSUE #5859]Optimize String#format in DefaultMQProducerImpl
    
    * polish code
---
 .../rocketmq/client/impl/producer/DefaultMQProducerImpl.java       | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git 
a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
 
b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
index 53224823f..3b825e52a 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
@@ -661,14 +661,14 @@ public class DefaultMQProducerImpl implements 
MQProducerInner {
                     } catch (RemotingException | MQClientException e) {
                         endTimestamp = System.currentTimeMillis();
                         this.updateFaultItem(mq.getBrokerName(), endTimestamp 
- beginTimestampPrev, true);
-                        log.warn(String.format("sendKernelImpl exception, 
resend at once, InvokeID: %s, RT: %sms, Broker: %s", invokeID, endTimestamp - 
beginTimestampPrev, mq), e);
+                        log.warn("sendKernelImpl exception, resend at once, 
InvokeID: %s, RT: %sms, Broker: %s", invokeID, endTimestamp - 
beginTimestampPrev, mq, e);
                         log.warn(msg.toString());
                         exception = e;
                         continue;
                     } catch (MQBrokerException e) {
                         endTimestamp = System.currentTimeMillis();
                         this.updateFaultItem(mq.getBrokerName(), endTimestamp 
- beginTimestampPrev, true);
-                        log.warn(String.format("sendKernelImpl exception, 
resend at once, InvokeID: %s, RT: %sms, Broker: %s", invokeID, endTimestamp - 
beginTimestampPrev, mq), e);
+                        log.warn("sendKernelImpl exception, resend at once, 
InvokeID: %s, RT: %sms, Broker: %s", invokeID, endTimestamp - 
beginTimestampPrev, mq, e);
                         log.warn(msg.toString());
                         exception = e;
                         if 
(this.defaultMQProducer.getRetryResponseCodes().contains(e.getResponseCode())) {
@@ -683,7 +683,7 @@ public class DefaultMQProducerImpl implements 
MQProducerInner {
                     } catch (InterruptedException e) {
                         endTimestamp = System.currentTimeMillis();
                         this.updateFaultItem(mq.getBrokerName(), endTimestamp 
- beginTimestampPrev, false);
-                        log.warn(String.format("sendKernelImpl exception, 
throw exception, InvokeID: %s, RT: %sms, Broker: %s", invokeID, endTimestamp - 
beginTimestampPrev, mq), e);
+                        log.warn("sendKernelImpl exception, throw exception, 
InvokeID: %s, RT: %sms, Broker: %s", invokeID, endTimestamp - 
beginTimestampPrev, mq, e);
                         log.warn(msg.toString());
                         throw e;
                     }
@@ -695,7 +695,6 @@ public class DefaultMQProducerImpl implements 
MQProducerInner {
             if (sendResult != null) {
                 return sendResult;
             }
-
             String info = String.format("Send [%d] times, still failed, cost 
[%d]ms, Topic: %s, BrokersSent: %s",
                 times,
                 System.currentTimeMillis() - beginTimestampFirst,