RongtongJin commented on code in PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879#discussion_r1088735121
##########
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java:
##########
@@ -211,8 +220,31 @@ public Boolean call() {
}
}
+ @Test
+ public void testPutTimerMessage() throws Exception {
+ initStore(false);
+ testPutTimerMessageCommon();
+ }
+
+ @Test
+ public void testDledgerPutTimerMessage() throws Exception {
+ initStore(true);
+ testPutTimerMessageCommon();
+ }
+
@Test
public void testTimerFlowControl() throws Exception {
+ initStore(false);
+ testTimerFlowControlCommon();
+ }
+
+ @Test
+ public void testDledgerTimerFlowControl() throws Exception {
+ initStore(true);
+ testTimerFlowControlCommon();
+ }
Review Comment:
Such a test is effective, but it will increase the test run time. I suggest
writing a single test or temporarily not adding the test related to DLedger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
