ShadowySpirits commented on code in PR #5926:
URL: https://github.com/apache/rocketmq/pull/5926#discussion_r1092720499
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/TieredStoreProvider.java:
##########
@@ -19,7 +19,7 @@
import java.nio.ByteBuffer;
import java.util.concurrent.CompletableFuture;
-public interface TieredStoreBackendProvider {
Review Comment:
The SPI mechanism is not applicable in this case. We want users to build
their own provider by extending TieredFileSegment, which is an abstract class,
not an interface. And tiered storage will create multiple file segment
instances in multiple threads. It's more suitable to use the class name to
initialize the file segment objects directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
