[rocketmq-connect] branch master updated: [ISSUE #411] Check taskConfigs (#412)

[zhoubo]

This is an automated email from the ASF dual-hosted git repository.

zhoubo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-connect.git


The following commit(s) were added to refs/heads/master by this push:
     new 92c14dac [ISSUE #411] Check taskConfigs (#412)
92c14dac is described below

commit 92c14dac8f5667b64aa532bdab411cb95bc18f2c
Author: Oliver <wqdyx...@163.com>
AuthorDate: Thu Feb 2 15:55:28 2023 +0800

    [ISSUE #411] Check taskConfigs (#412)
---
 .../connect/runtime/service/AbstractConfigManagementService.java     | 5 +++++
 1 file changed, 5 insertions(+)

diff --git 
a/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/AbstractConfigManagementService.java
 
b/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/AbstractConfigManagementService.java
index cbdcc45a..69340567 100644
--- 
a/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/AbstractConfigManagementService.java
+++ 
b/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/AbstractConfigManagementService.java
@@ -19,6 +19,8 @@ package org.apache.rocketmq.connect.runtime.service;
 
 import io.openmessaging.KeyValue;
 import io.openmessaging.connector.api.component.connector.Connector;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.rocketmq.connect.runtime.common.ConfigException;
 import org.apache.rocketmq.connect.runtime.common.ConnectKeyValue;
 import org.apache.rocketmq.connect.runtime.config.ConnectorConfig;
 import org.apache.rocketmq.connect.runtime.config.SinkConnectorConfig;
@@ -67,6 +69,9 @@ public abstract class AbstractConfigManagementService 
implements ConfigManagemen
         // load connector
         Connector connector = loadConnector(configs);
         List<KeyValue> taskConfigs = connector.taskConfigs(maxTask);
+        if (CollectionUtils.isEmpty(taskConfigs)) {
+            throw new ConfigException("The connector  " + connectorName + " 
taskConfigs is empty, Please check configuration");
+        }
         List<ConnectKeyValue> converterdConfigs = new ArrayList<>();
         int taskId = 0;
         for (KeyValue keyValue : taskConfigs) {