fuyou001 commented on code in PR #5887:
URL: https://github.com/apache/rocketmq/pull/5887#discussion_r1096863845
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -2743,6 +2852,269 @@ public String getServiceName() {
}
+ class MainBatchDispatchRequestService extends ServiceThread {
+
+ private final ExecutorService batchDispatchRequestExecutor;
+
+ public MainBatchDispatchRequestService() {
+ batchDispatchRequestExecutor = new ThreadPoolExecutor(
+
DefaultMessageStore.this.getBrokerConfig().getBatchDispatchRequestThreadPoolNums(),
+
DefaultMessageStore.this.getBrokerConfig().getBatchDispatchRequestThreadPoolNums(),
+ 1000 * 60,
+ TimeUnit.MICROSECONDS,
+ new LinkedBlockingQueue<>(4096),
+ new
ThreadFactoryImpl("BatchDispatchRequestServiceThread_"),
+ new RejectedExecutionHandler() {
+ @Override
+ public void rejectedExecution(Runnable r,
ThreadPoolExecutor executor) {
+ try {
+ LOGGER.warn("Task {} is blocking put into the
workQueue", r);
+ executor.getQueue().put(r);
+ } catch (InterruptedException e) {
+ LOGGER.error("Task {} failed to put into the
workQueue", r);
+ }
+ }
+ });
+ }
+
+ private void pollBatchDispatchRequest() {
+ if (!batchDispatchRequestQueue.isEmpty()) {
+ BatchDispatchRequest task = batchDispatchRequestQueue.poll();
+ batchDispatchRequestExecutor.execute(() -> {
+ ByteBuffer tmpByteBuffer = task.byteBuffer.duplicate();
+ tmpByteBuffer.position(task.position);
+ tmpByteBuffer.limit(task.position + task.size);
+ List<DispatchRequest> dispatchRequestList = new
ArrayList<>();
+ while (tmpByteBuffer.hasRemaining()) {
+ DispatchRequest dispatchRequest =
DefaultMessageStore.this.commitLog.checkMessageAndReturnSize(tmpByteBuffer,
false, false, false);
+ if (dispatchRequest.isSuccess()) {
+ dispatchRequestList.add(dispatchRequest);
+ } else {
+ LOGGER.error("[BUG]read total count not equals msg
total size.");
+ }
+ }
+ dispatchRequestOrderlyQueue.put(task.id,
dispatchRequestList.toArray(new DispatchRequest[dispatchRequestList.size()]));
+ mappedPageHoldCount.getAndDecrement();
+ });
+ }
+ }
+
+ @Override
+ public void run() {
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
started");
+
+ while (!this.isStopped()) {
+ try {
+ TimeUnit.MILLISECONDS.sleep(1);
+ pollBatchDispatchRequest();
+ } catch (Exception e) {
+ DefaultMessageStore.LOGGER.warn(this.getServiceName() + "
service has exception. ", e);
+ }
+ }
+
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
end");
+ }
+
+ @Override
+ public String getServiceName() {
+ if
(DefaultMessageStore.this.getBrokerConfig().isInBrokerContainer()) {
+ return
DefaultMessageStore.this.getBrokerIdentity().getIdentifier() +
MainBatchDispatchRequestService.class.getSimpleName();
+ }
+ return MainBatchDispatchRequestService.class.getSimpleName();
+ }
+
+ }
+
+ class DispatchService extends ServiceThread {
+
+ private final List<DispatchRequest[]> dispatchRequestsList = new
ArrayList<>();
+
+ private void dispatch() {
+ dispatchRequestsList.clear();
+ dispatchRequestOrderlyQueue.get(dispatchRequestsList);
+ if (!dispatchRequestsList.isEmpty()) {
+ for (DispatchRequest[] dispatchRequests :
dispatchRequestsList) {
+ for (DispatchRequest dispatchRequest : dispatchRequests) {
+ DefaultMessageStore.this.doDispatch(dispatchRequest);
+ // wake up long-polling
+ if
(DefaultMessageStore.this.brokerConfig.isLongPollingEnable()
+ &&
DefaultMessageStore.this.messageArrivingListener != null) {
+
DefaultMessageStore.this.messageArrivingListener.arriving(dispatchRequest.getTopic(),
+ dispatchRequest.getQueueId(),
dispatchRequest.getConsumeQueueOffset() + 1,
+ dispatchRequest.getTagsCode(),
dispatchRequest.getStoreTimestamp(),
+ dispatchRequest.getBitMap(),
dispatchRequest.getPropertiesMap());
+
DefaultMessageStore.this.reputMessageService.notifyMessageArrive4MultiQueue(dispatchRequest);
+ }
+ if
(!DefaultMessageStore.this.getMessageStoreConfig().isDuplicationEnable() &&
+
DefaultMessageStore.this.getMessageStoreConfig().getBrokerRole() ==
BrokerRole.SLAVE) {
+ DefaultMessageStore.this.storeStatsService
+
.getSinglePutMessageTopicTimesTotal(dispatchRequest.getTopic()).add(1);
+ DefaultMessageStore.this.storeStatsService
+
.getSinglePutMessageTopicSizeTotal(dispatchRequest.getTopic())
+ .add(dispatchRequest.getMsgSize());
+ }
+ }
+ }
+ }
+ }
+
+ @Override
+ public void run() {
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
started");
+
+ while (!this.isStopped()) {
+ try {
+ TimeUnit.MILLISECONDS.sleep(1);
+ dispatch();
+ } catch (Exception e) {
+ DefaultMessageStore.LOGGER.warn(this.getServiceName() + "
service has exception. ", e);
+ }
+ }
+
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
end");
+ }
+
+ @Override
+ public String getServiceName() {
+ if
(DefaultMessageStore.this.getBrokerConfig().isInBrokerContainer()) {
+ return
DefaultMessageStore.this.getBrokerIdentity().getIdentifier() +
DispatchService.class.getSimpleName();
+ }
+ return DispatchService.class.getSimpleName();
+ }
+ }
+
+ class ConcurrentReputMessageService extends ReputMessageService {
+
+ private static final int BATCH_SIZE = 1024 * 1024 * 4;
+
+ private int batchId = 0;
Review Comment:
batchId type change long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
