drpmma commented on code in PR #5887:
URL: https://github.com/apache/rocketmq/pull/5887#discussion_r1104340762
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -2743,6 +2835,291 @@ public String getServiceName() {
}
+ class MainBatchDispatchRequestService extends ServiceThread {
+
+ private final ExecutorService batchDispatchRequestExecutor;
+
+ public MainBatchDispatchRequestService() {
+ batchDispatchRequestExecutor = new ThreadPoolExecutor(
+
DefaultMessageStore.this.getBrokerConfig().getBatchDispatchRequestThreadPoolNums(),
+
DefaultMessageStore.this.getBrokerConfig().getBatchDispatchRequestThreadPoolNums(),
+ 1000 * 60,
+ TimeUnit.MICROSECONDS,
+ new LinkedBlockingQueue<>(4096),
+ new
ThreadFactoryImpl("BatchDispatchRequestServiceThread_"),
+ new ThreadPoolExecutor.AbortPolicy());
+ }
+
+ private void pollBatchDispatchRequest() {
+ try {
+ if (!batchDispatchRequestQueue.isEmpty()) {
+ BatchDispatchRequest task =
batchDispatchRequestQueue.peek();
+ batchDispatchRequestExecutor.execute(() -> {
+ try {
+ ByteBuffer tmpByteBuffer =
task.byteBuffer.duplicate();
+ tmpByteBuffer.position(task.position);
+ tmpByteBuffer.limit(task.position + task.size);
+ List<DispatchRequest> dispatchRequestList = new
ArrayList<>();
+ while (tmpByteBuffer.hasRemaining()) {
+ DispatchRequest dispatchRequest =
DefaultMessageStore.this.commitLog.checkMessageAndReturnSize(tmpByteBuffer,
false, false, false);
+ if (dispatchRequest.isSuccess()) {
+ dispatchRequestList.add(dispatchRequest);
+ } else {
+ LOGGER.error("[BUG]read total count not
equals msg total size.");
+ }
+ }
+ dispatchRequestOrderlyQueue.put(task.id,
dispatchRequestList.toArray(new DispatchRequest[dispatchRequestList.size()]));
+ mappedPageHoldCount.getAndDecrement();
+ } catch (Exception e) {
+ LOGGER.error("There is an exception in task
execution.", e);
+ }
+ });
+ batchDispatchRequestQueue.poll();
+ }
+ } catch (Exception e) {
+ DefaultMessageStore.LOGGER.warn(this.getServiceName() + "
service has exception. ", e);
+ }
+ }
+
+ @Override
+ public void run() {
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
started");
+
+ while (!this.isStopped()) {
+ try {
+ TimeUnit.MILLISECONDS.sleep(1);
+ pollBatchDispatchRequest();
+ } catch (Exception e) {
+ DefaultMessageStore.LOGGER.warn(this.getServiceName() + "
service has exception. ", e);
+ }
+ }
+
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
end");
+ }
+
+ @Override
+ public String getServiceName() {
+ if
(DefaultMessageStore.this.getBrokerConfig().isInBrokerContainer()) {
+ return
DefaultMessageStore.this.getBrokerIdentity().getIdentifier() +
MainBatchDispatchRequestService.class.getSimpleName();
+ }
+ return MainBatchDispatchRequestService.class.getSimpleName();
+ }
+
+ }
+
+ class DispatchService extends ServiceThread {
+
+ private final List<DispatchRequest[]> dispatchRequestsList = new
ArrayList<>();
+
+ private void dispatch() {
+ dispatchRequestsList.clear();
+ dispatchRequestOrderlyQueue.get(dispatchRequestsList);
+ if (!dispatchRequestsList.isEmpty()) {
+ for (DispatchRequest[] dispatchRequests :
dispatchRequestsList) {
+ for (DispatchRequest dispatchRequest : dispatchRequests) {
+ DefaultMessageStore.this.doDispatch(dispatchRequest);
+ // wake up long-polling
+ if
(DefaultMessageStore.this.brokerConfig.isLongPollingEnable()
+ &&
DefaultMessageStore.this.messageArrivingListener != null) {
+
DefaultMessageStore.this.messageArrivingListener.arriving(dispatchRequest.getTopic(),
+ dispatchRequest.getQueueId(),
dispatchRequest.getConsumeQueueOffset() + 1,
+ dispatchRequest.getTagsCode(),
dispatchRequest.getStoreTimestamp(),
+ dispatchRequest.getBitMap(),
dispatchRequest.getPropertiesMap());
+
DefaultMessageStore.this.reputMessageService.notifyMessageArrive4MultiQueue(dispatchRequest);
+ }
+ if
(!DefaultMessageStore.this.getMessageStoreConfig().isDuplicationEnable() &&
+
DefaultMessageStore.this.getMessageStoreConfig().getBrokerRole() ==
BrokerRole.SLAVE) {
+ DefaultMessageStore.this.storeStatsService
+
.getSinglePutMessageTopicTimesTotal(dispatchRequest.getTopic()).add(1);
+ DefaultMessageStore.this.storeStatsService
+
.getSinglePutMessageTopicSizeTotal(dispatchRequest.getTopic())
+ .add(dispatchRequest.getMsgSize());
+ }
+ }
+ }
+ }
+ }
+
+ @Override
+ public void run() {
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
started");
+
+ while (!this.isStopped()) {
+ try {
+ TimeUnit.MILLISECONDS.sleep(1);
+ dispatch();
+ } catch (Exception e) {
+ DefaultMessageStore.LOGGER.warn(this.getServiceName() + "
service has exception. ", e);
+ }
+ }
+
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
end");
+ }
+
+ @Override
+ public String getServiceName() {
+ if
(DefaultMessageStore.this.getBrokerConfig().isInBrokerContainer()) {
+ return
DefaultMessageStore.this.getBrokerIdentity().getIdentifier() +
DispatchService.class.getSimpleName();
+ }
+ return DispatchService.class.getSimpleName();
+ }
+ }
+
+ class ConcurrentReputMessageService extends ReputMessageService {
+
+ private static final int BATCH_SIZE = 1024 * 1024 * 4;
+
+ private long batchId = 0;
+
+ private MainBatchDispatchRequestService
mainBatchDispatchRequestService;
+
+ private DispatchService dispatchService;
+
+ public ConcurrentReputMessageService() {
+ super();
+ this.mainBatchDispatchRequestService = new
MainBatchDispatchRequestService();
+ this.dispatchService = new DispatchService();
+ }
+
+ public void createBatchDispatchRequest(ByteBuffer byteBuffer, int
position, int size) {
+ if (position < 0) {
+ return;
+ }
+ mappedPageHoldCount.getAndIncrement();
+ BatchDispatchRequest task = new BatchDispatchRequest(byteBuffer,
position, size, batchId++);
+ batchDispatchRequestQueue.offer(task);
+ }
+
+ @Override
+ public void start() {
+ super.start();
+ this.mainBatchDispatchRequestService.start();
+ this.dispatchService.start();
+ }
+
+ @Override
+ public void doReput() {
+ if (this.reputFromOffset <
DefaultMessageStore.this.commitLog.getMinOffset()) {
+ LOGGER.warn("The reputFromOffset={} is smaller than
minPyOffset={}, this usually indicate that the dispatch behind too much and the
commitlog has expired.",
+ this.reputFromOffset,
DefaultMessageStore.this.commitLog.getMinOffset());
+ this.reputFromOffset =
DefaultMessageStore.this.commitLog.getMinOffset();
+ }
+ for (boolean doNext = true; this.isCommitLogAvailable() && doNext;
) {
+
+ SelectMappedBufferResult result =
DefaultMessageStore.this.commitLog.getData(reputFromOffset);
+
+ if (result == null) {
+ break;
+ }
+
+ int batchDispatchRequestStart = -1;
+ int batchDispatchRequestSize = -1;
+ try {
+ this.reputFromOffset = result.getStartOffset();
+
+ for (int readSize = 0; readSize < result.getSize() &&
reputFromOffset < DefaultMessageStore.this.getConfirmOffset() && doNext; ) {
+ ByteBuffer byteBuffer = result.getByteBuffer();
+
+ int totalSize =
preCheckMessageAndReturnSize(byteBuffer);
+
+ if (totalSize > 0) {
+ if (batchDispatchRequestStart == -1) {
+ batchDispatchRequestStart =
byteBuffer.position();
+ batchDispatchRequestSize = 0;
+ }
+ batchDispatchRequestSize += totalSize;
+ if (batchDispatchRequestSize > BATCH_SIZE) {
Review Comment:
BATCH_SIZE can be assigned from MessageStoreConfig here which that it will
only take effect when broker startup.
https://github.com/apache/rocketmq/blob/02577ed7230a3587cb04ba65abdd6870230c4d7e/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java#L2970
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -2743,6 +2835,291 @@ public String getServiceName() {
}
+ class MainBatchDispatchRequestService extends ServiceThread {
+
+ private final ExecutorService batchDispatchRequestExecutor;
+
+ public MainBatchDispatchRequestService() {
+ batchDispatchRequestExecutor = new ThreadPoolExecutor(
+
DefaultMessageStore.this.getBrokerConfig().getBatchDispatchRequestThreadPoolNums(),
+
DefaultMessageStore.this.getBrokerConfig().getBatchDispatchRequestThreadPoolNums(),
+ 1000 * 60,
+ TimeUnit.MICROSECONDS,
+ new LinkedBlockingQueue<>(4096),
+ new
ThreadFactoryImpl("BatchDispatchRequestServiceThread_"),
+ new ThreadPoolExecutor.AbortPolicy());
+ }
+
+ private void pollBatchDispatchRequest() {
+ try {
+ if (!batchDispatchRequestQueue.isEmpty()) {
+ BatchDispatchRequest task =
batchDispatchRequestQueue.peek();
+ batchDispatchRequestExecutor.execute(() -> {
+ try {
+ ByteBuffer tmpByteBuffer =
task.byteBuffer.duplicate();
+ tmpByteBuffer.position(task.position);
+ tmpByteBuffer.limit(task.position + task.size);
+ List<DispatchRequest> dispatchRequestList = new
ArrayList<>();
+ while (tmpByteBuffer.hasRemaining()) {
+ DispatchRequest dispatchRequest =
DefaultMessageStore.this.commitLog.checkMessageAndReturnSize(tmpByteBuffer,
false, false, false);
+ if (dispatchRequest.isSuccess()) {
+ dispatchRequestList.add(dispatchRequest);
+ } else {
+ LOGGER.error("[BUG]read total count not
equals msg total size.");
+ }
+ }
+ dispatchRequestOrderlyQueue.put(task.id,
dispatchRequestList.toArray(new DispatchRequest[dispatchRequestList.size()]));
+ mappedPageHoldCount.getAndDecrement();
+ } catch (Exception e) {
+ LOGGER.error("There is an exception in task
execution.", e);
+ }
+ });
+ batchDispatchRequestQueue.poll();
+ }
+ } catch (Exception e) {
+ DefaultMessageStore.LOGGER.warn(this.getServiceName() + "
service has exception. ", e);
+ }
+ }
+
+ @Override
+ public void run() {
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
started");
+
+ while (!this.isStopped()) {
+ try {
+ TimeUnit.MILLISECONDS.sleep(1);
+ pollBatchDispatchRequest();
+ } catch (Exception e) {
+ DefaultMessageStore.LOGGER.warn(this.getServiceName() + "
service has exception. ", e);
+ }
+ }
+
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
end");
+ }
+
+ @Override
+ public String getServiceName() {
+ if
(DefaultMessageStore.this.getBrokerConfig().isInBrokerContainer()) {
+ return
DefaultMessageStore.this.getBrokerIdentity().getIdentifier() +
MainBatchDispatchRequestService.class.getSimpleName();
+ }
+ return MainBatchDispatchRequestService.class.getSimpleName();
+ }
+
+ }
+
+ class DispatchService extends ServiceThread {
+
+ private final List<DispatchRequest[]> dispatchRequestsList = new
ArrayList<>();
+
+ private void dispatch() {
+ dispatchRequestsList.clear();
+ dispatchRequestOrderlyQueue.get(dispatchRequestsList);
+ if (!dispatchRequestsList.isEmpty()) {
+ for (DispatchRequest[] dispatchRequests :
dispatchRequestsList) {
+ for (DispatchRequest dispatchRequest : dispatchRequests) {
+ DefaultMessageStore.this.doDispatch(dispatchRequest);
+ // wake up long-polling
+ if
(DefaultMessageStore.this.brokerConfig.isLongPollingEnable()
+ &&
DefaultMessageStore.this.messageArrivingListener != null) {
+
DefaultMessageStore.this.messageArrivingListener.arriving(dispatchRequest.getTopic(),
+ dispatchRequest.getQueueId(),
dispatchRequest.getConsumeQueueOffset() + 1,
+ dispatchRequest.getTagsCode(),
dispatchRequest.getStoreTimestamp(),
+ dispatchRequest.getBitMap(),
dispatchRequest.getPropertiesMap());
+
DefaultMessageStore.this.reputMessageService.notifyMessageArrive4MultiQueue(dispatchRequest);
+ }
+ if
(!DefaultMessageStore.this.getMessageStoreConfig().isDuplicationEnable() &&
+
DefaultMessageStore.this.getMessageStoreConfig().getBrokerRole() ==
BrokerRole.SLAVE) {
+ DefaultMessageStore.this.storeStatsService
+
.getSinglePutMessageTopicTimesTotal(dispatchRequest.getTopic()).add(1);
+ DefaultMessageStore.this.storeStatsService
+
.getSinglePutMessageTopicSizeTotal(dispatchRequest.getTopic())
+ .add(dispatchRequest.getMsgSize());
+ }
+ }
+ }
+ }
+ }
+
+ @Override
+ public void run() {
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
started");
+
+ while (!this.isStopped()) {
+ try {
+ TimeUnit.MILLISECONDS.sleep(1);
+ dispatch();
+ } catch (Exception e) {
+ DefaultMessageStore.LOGGER.warn(this.getServiceName() + "
service has exception. ", e);
+ }
+ }
+
+ DefaultMessageStore.LOGGER.info(this.getServiceName() + " service
end");
+ }
+
+ @Override
+ public String getServiceName() {
+ if
(DefaultMessageStore.this.getBrokerConfig().isInBrokerContainer()) {
+ return
DefaultMessageStore.this.getBrokerIdentity().getIdentifier() +
DispatchService.class.getSimpleName();
+ }
+ return DispatchService.class.getSimpleName();
+ }
+ }
+
+ class ConcurrentReputMessageService extends ReputMessageService {
+
+ private static final int BATCH_SIZE = 1024 * 1024 * 4;
+
+ private long batchId = 0;
+
+ private MainBatchDispatchRequestService
mainBatchDispatchRequestService;
+
+ private DispatchService dispatchService;
+
+ public ConcurrentReputMessageService() {
+ super();
+ this.mainBatchDispatchRequestService = new
MainBatchDispatchRequestService();
+ this.dispatchService = new DispatchService();
+ }
+
+ public void createBatchDispatchRequest(ByteBuffer byteBuffer, int
position, int size) {
+ if (position < 0) {
+ return;
+ }
+ mappedPageHoldCount.getAndIncrement();
+ BatchDispatchRequest task = new BatchDispatchRequest(byteBuffer,
position, size, batchId++);
+ batchDispatchRequestQueue.offer(task);
+ }
+
+ @Override
+ public void start() {
+ super.start();
+ this.mainBatchDispatchRequestService.start();
+ this.dispatchService.start();
+ }
+
+ @Override
+ public void doReput() {
+ if (this.reputFromOffset <
DefaultMessageStore.this.commitLog.getMinOffset()) {
+ LOGGER.warn("The reputFromOffset={} is smaller than
minPyOffset={}, this usually indicate that the dispatch behind too much and the
commitlog has expired.",
+ this.reputFromOffset,
DefaultMessageStore.this.commitLog.getMinOffset());
+ this.reputFromOffset =
DefaultMessageStore.this.commitLog.getMinOffset();
+ }
+ for (boolean doNext = true; this.isCommitLogAvailable() && doNext;
) {
+
+ SelectMappedBufferResult result =
DefaultMessageStore.this.commitLog.getData(reputFromOffset);
+
+ if (result == null) {
+ break;
+ }
+
+ int batchDispatchRequestStart = -1;
+ int batchDispatchRequestSize = -1;
+ try {
+ this.reputFromOffset = result.getStartOffset();
+
+ for (int readSize = 0; readSize < result.getSize() &&
reputFromOffset < DefaultMessageStore.this.getConfirmOffset() && doNext; ) {
+ ByteBuffer byteBuffer = result.getByteBuffer();
+
+ int totalSize =
preCheckMessageAndReturnSize(byteBuffer);
+
+ if (totalSize > 0) {
+ if (batchDispatchRequestStart == -1) {
+ batchDispatchRequestStart =
byteBuffer.position();
+ batchDispatchRequestSize = 0;
+ }
+ batchDispatchRequestSize += totalSize;
+ if (batchDispatchRequestSize > BATCH_SIZE) {
Review Comment:
BATCH_SIZE can be assigned from MessageStoreConfig here it will only take
effect when broker startup.
https://github.com/apache/rocketmq/blob/02577ed7230a3587cb04ba65abdd6870230c4d7e/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java#L2970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
