echooymxq commented on code in PR #6115:
URL: https://github.com/apache/rocketmq/pull/6115#discussion_r1111383228
##########
tools/src/main/java/org/apache/rocketmq/tools/command/message/QueryMsgTraceByIdSubCommand.java:
##########
@@ -47,6 +47,19 @@ public Options buildCommandlineOptions(Options options) {
opt = new Option("t", "traceTopic", true, "The name value of message
trace topic");
opt.setRequired(false);
options.addOption(opt);
+
+ opt = new Option("b", "beginTimestamp", true, "Begin timestamp(ms).
default:0, eg:1676730526212");
+ opt.setRequired(false);
+ options.addOption(opt);
+
+ opt = new Option("e", "endTimestamp", true, "End timestamp(ms).
default:Long.MAX_VALUE, eg:1676730526212");
+ opt.setRequired(false);
+ options.addOption(opt);
+
+ opt = new Option("num", "maxNum", true, "The maximum number of
messages returned by the query, default:64");
Review Comment:
How about change the option name to `c`(messageNumber), like the
`ConsumeMessageCommand`. Simple unified use of single letter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
