ShadowySpirits commented on code in PR #6142:
URL: https://github.com/apache/rocketmq/pull/6142#discussion_r1112673091
##########
broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java:
##########
@@ -211,6 +213,9 @@ public SubscriptionGroupConfig
findSubscriptionGroupConfig(final String group) {
SubscriptionGroupConfig subscriptionGroupConfig =
this.subscriptionGroupTable.get(group);
if (null == subscriptionGroupConfig) {
if
(brokerController.getBrokerConfig().isAutoCreateSubscriptionGroup() ||
MixAll.isSysConsumerGroup(group)) {
+ if (group.length() > Validators.CHARACTER_MAX_LENGTH ||
TopicValidator.isTopicOrGroupIllegal(group)) {
Review Comment:
How about preventing the automatic creation of system groups?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
