yiduwangkai opened a new pull request, #6270:
URL: https://github.com/apache/rocketmq/pull/6270

   Make sure set the target branch to develop
   
   What is the purpose of the change
   When i run rocketmq 5.0 in test, The current offset is greater than 
maxoffset when the exact delay has not been used for some time
   This submission is to add max offset assign to fix this bug
   
   Brief changelog
   change TimerMessageStore
   
   Verifying this change
   i run delay message for many days, when i try to sole it like i summitted 
code
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR.
   
    Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue.
    Format the pull request title like [ISSUE #123] Fix UnknownException when 
host config not exist. Each commit in the pull request should have a meaningful 
subject line and body.
    Write a pull request description that is detailed enough to understand what 
the pull request does, how, and why.
    Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
    Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle 
to make sure basic checks pass. Run mvn clean install -DskipITs to make sure 
unit-test pass. Run mvn clean test-compile failsafe:integration-test to make 
sure integration-test pass.
    If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to