ShadowySpirits commented on code in PR #527:
URL: https://github.com/apache/rocketmq-site/pull/527#discussion_r1128931354


##########
i18n/en/docusaurus-plugin-content-docs/version-5.0/12-observability/01metrics.md:
##########
@@ -54,45 +55,82 @@ The following table describes the labels of the metrics 
that are related to the
 - client_id: the ID of the client.
 - invocation_status: the result of the API call for sending messages, which 
includes success and failure.
 
-| Type | Name | Unit | Description | Label |
-| --- | ----- | --- | ---------- | --- |
+| Type      | Name                    | Unit        | Description              
                                                                                
                                                                                
                          | Label                             |
+| --------- | ----------------------- | ----------- | 
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 | --------------------------------- |
 | Histogram | rocketmq_send_cost_time | millisecond | The distribution of 
production API call time. The following shows the distribution ranges: <br 
/>le_1_ms <br />le_5_ms<br />le_10_ms<br />le_20_ms <br />le_50_ms <br 
/>le_200_ms<br />le_500_ms <br />le_overflow | 
topic,client_id,invocation_status |
 
-
 ### Consumer metrics
+
 The following table describes the labels of the metrics that are related to 
the consumers in Message Queue for Apache RocketMQ.
 
 - topic: the topic of Message Queue for Apache RocketMQ.
 - consumer_group: the ID of the consumer group.
 - client_id: the ID of the client.
 - invocation_status: the result of the API call for sending messages, which 
includes success and failure.
 
-| Type | Name | Unit | Description | Label |
-| --- | ----- | --- | ---------- | --- |
-| Histogram | rocketmq_process_time | millisecond | The distribution of 
message process time.The following shows the distribution ranges: <br />le_1_ms 
<br />le_5_ms  <br />le_10_ms<br />le_100_ms <br />le_10000_ms<br />le_60000_ms 
<br />le_overflow | topic,consumer_group,client_id,invocation_status |
-| gauge | rocketmq_consumer_cached_messages | message | The number of messages 
in the local buffer queue of PushConsumer. | topic,consumer_group,client_id |
-| gauge | rocketmq_consumer_cached_bytes | byte | The total size of messages 
in the local buffer queue of PushConsumer. | topic,consumer_group,client_id |
-| Histogram | rocketmq_await_time | millisecond | The distribution of queuing 
time for messages in the local buffer queue of PushConsumer. The following 
shows the distribution ranges:<br />le_1_ms<br /> le_5_ms<br />le_20_ms<br 
/>le_100_ms <br />le_1000_ms<br /> le_5000_ms <br />le_10000_ms<br 
/>le_overflow | topic,consumer_group,client_id |
-
+| Type      | Name                              | Unit        | Description    
                                                                                
                                                                                
                                                                                
    | Label                                            |
+| --------- | --------------------------------- | ----------- | 
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 | ------------------------------------------------ |
+| Histogram | rocketmq_process_time             | millisecond | The 
distribution of message process time.The following shows the distribution 
ranges: <br />le_1_ms <br />le_5_ms  <br />le_10_ms<br />le_100_ms <br 
/>le_10000_ms<br />le_60000_ms <br />le_overflow                                
                              | 
topic,consumer_group,client_id,invocation_status |
+| gauge     | rocketmq_consumer_cached_messages | message     | The number of 
messages in the local buffer queue of PushConsumer.                             
                                                                                
                                                                                
     | topic,consumer_group,client_id                   |

Review Comment:
   `rocketmq_consumer_cached_messages` is a gauge and 
`rocketmq_messages_in_total` is a counter. It makes sense that these two 
metrics with the different suffixes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to