drpmma commented on code in PR #6271:
URL: https://github.com/apache/rocketmq/pull/6271#discussion_r1130532397
##########
proxy/src/main/java/org/apache/rocketmq/proxy/processor/ReceiptHandleProcessor.java:
##########
@@ -175,9 +175,10 @@ protected CompletableFuture<MessageReceiptHandle>
startRenewMessage(MessageRecei
return CompletableFuture.completedFuture(null);
}
if (current - messageReceiptHandle.getConsumeTimestamp() <
proxyConfig.getRenewMaxTimeMillis()) {
+ RetryPolicy renewPolicy =
messageReceiptHandle.getRenewStrategyPolicy();
CompletableFuture<AckResult> future =
messagingProcessor.changeInvisibleTime(context, handle,
messageReceiptHandle.getMessageId(),
- messageReceiptHandle.getGroup(),
messageReceiptHandle.getTopic(), proxyConfig.getRenewSliceTimeMillis());
+ messageReceiptHandle.getGroup(),
messageReceiptHandle.getTopic(),
renewPolicy.nextDelayDuration(messageReceiptHandle.getRenewRetryTimes()));
Review Comment:
The renew time has no relationship with retry times. The retry time is about
message consumption failure while the renew time is about splitting time from
invisible time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
