xdkxlk commented on code in PR #6262:
URL: https://github.com/apache/rocketmq/pull/6262#discussion_r1130585870
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/route/RouteActivity.java:
##########
@@ -162,12 +161,11 @@ protected Permission convertToPermission(int perm) {
}
protected List<org.apache.rocketmq.proxy.common.Address>
convertToAddressList(Endpoints endpoints) {
- int port = ConfigurationManager.getProxyConfig().getGrpcServerPort();
List<org.apache.rocketmq.proxy.common.Address> addressList = new
ArrayList<>();
for (Address address : endpoints.getAddressesList()) {
addressList.add(new org.apache.rocketmq.proxy.common.Address(
org.apache.rocketmq.proxy.common.Address.AddressScheme.valueOf(endpoints.getScheme().name()),
- HostAndPort.fromParts(address.getHost(), port))
+ HostAndPort.fromParts(address.getHost(), address.getPort()))
Review Comment:
Add a configuration to decide whether to use the configured port in
proxyConfig or the port in the endpoint is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
