Oliverwqcwrw commented on code in PR #150:
URL:
https://github.com/apache/rocketmq-dashboard/pull/150#discussion_r1135494241
##########
.vscode/settings.json:
##########
Review Comment:
The file is not needed,
BTW, the gitignore should be updated to avoid submitting the vscode file.
##########
pom.xml:
##########
@@ -94,7 +94,7 @@
<rocketmq.version>4.9.3</rocketmq.version>
Review Comment:
We should upgrade to version 5.1.0 to support copying messageType from
TopicConfig to TopicConfigInfo.
By the way, messageType should come from the attributes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
