buptxxb65 commented on code in PR #6417:
URL: https://github.com/apache/rocketmq/pull/6417#discussion_r1145617754
##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java:
##########
@@ -860,9 +861,16 @@ public class PullTaskImpl implements Runnable {
private final MessageQueue messageQueue;
private volatile boolean cancelled = false;
private Thread currentThread;
+ private final CommunicationMode communicationMode;
public PullTaskImpl(final MessageQueue messageQueue) {
this.messageQueue = messageQueue;
+ communicationMode = CommunicationMode.SYNC;
+ }
+
+ public PullTaskImpl(final MessageQueue messageQueue, CommunicationMode
communicationMode) {
+ this.messageQueue = messageQueue;
+ this.communicationMode = communicationMode;
Review Comment:
Thank you for your approval! Based on your suggestion, I think we can keep
this constructor to facilitate our testing of asynchronous pull. Besides, what
else can I do for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
