GenerousMan commented on code in PR #6364:
URL: https://github.com/apache/rocketmq/pull/6364#discussion_r1145698259
##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java:
##########
@@ -521,7 +521,13 @@ private boolean updateProcessQueueTableInRebalance(final
String topic, final Set
this.removeDirtyOffset(mq);
ProcessQueue pq = createProcessQueue(topic);
pq.setLocked(true);
- long nextOffset = this.computePullFromWhere(mq);
+ long nextOffset;
+ try {
+ nextOffset = this.computePullFromWhereWithException(mq);
+ } catch (MQClientException e) {
+ log.info("doRebalance, {}, compute offset failed, {}",
consumerGroup, mq);
Review Comment:
maybe log.info() can be replaced with log.warn()?
Does it need to be consistent with the following codes?
` log.warn("doRebalance, {}, add new mq failed, {}", consumerGroup, mq);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
