Anakin100100 commented on issue #294:
URL:
https://github.com/apache/rocketmq-clients/issues/294#issuecomment-1487207976
I don't think there is a data race there. The getClientId function reads the
clientId property and returns a string copy. This could cause a data race only
if this value was mutated after the defaultClient object was created but I
haven't found any examples of that happening.
```
if !metric.GetOn() {
dcmp.clientMeter.shutdown()
sugarBaseLogger.Infof("metric is off, clientId=%s",
dcmp.client.GetClientID())
dcmp.clientMeter = NewDefaultClientMeter(nil, false, nil,
dcmp.client.GetClientID()) // DATA RACE
return
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
