This is an automated email from the ASF dual-hosted git repository.
fuyou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git
The following commit(s) were added to refs/heads/master by this push:
new 0a55ef5f fix format log (#455)
0a55ef5f is described below
commit 0a55ef5f6d93318de0db2853e39f3578038c7969
Author: yuz10 <[email protected]>
AuthorDate: Mon Apr 3 09:08:23 2023 +0800
fix format log (#455)
* fix format log
* fix test
* fix
---
golang/client.go | 6 +++---
golang/client_test.go | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/golang/client.go b/golang/client.go
index ce4f9b6a..fbd3ef8a 100644
--- a/golang/client.go
+++ b/golang/client.go
@@ -118,7 +118,7 @@ func (cs *defaultClientSession) startUp() {
cs.recovering = true
} else {
// we are recovering but we failed to
read the message again, resetting observer
- cs.cli.log.Info("Failed to recover,
err=%w", err)
+ cs.cli.log.Infof("Failed to recover,
err=%v", err)
cs.release()
cs.recovering = false
}
@@ -470,13 +470,13 @@ func (cli *defaultClient)
mustSyncSettingsToTargert(target string) error {
func (cli *defaultClient) telemeter(target string, command
*v2.TelemetryCommand) error {
cs, err := cli.getDefaultClientSession(target)
if err != nil {
- cli.log.Error("getDefaultClientSession failed, err=%v", target,
err)
+ cli.log.Errorf("getDefaultClientSession %s failed, err=%v",
target, err)
return err
}
ctx := cli.Sign(context.Background())
err = cs.publish(ctx, command)
if err != nil {
- cli.log.Error("telemeter to %s failed, err=%v", target, err)
+ cli.log.Errorf("telemeter to %s failed, err=%v", target, err)
return err
}
cli.log.Infof("telemeter to %s success", target)
diff --git a/golang/client_test.go b/golang/client_test.go
index 2ed17343..b46d2d73 100644
--- a/golang/client_test.go
+++ b/golang/client_test.go
@@ -291,5 +291,5 @@ func TestRestoreDefaultClientSessionTwoErrors(t *testing.T)
{
sugarBaseLogger.Info(observedLogs.All())
commandExecutionLog := observedLogs.All()[:2]
assert.Equal(t, "Encountered error while receiving TelemetryCommand,
trying to recover", commandExecutionLog[0].Message)
- assert.Equal(t, "Failed to recover, err=%wEOF",
commandExecutionLog[1].Message)
+ assert.Equal(t, "Failed to recover, err=EOF",
commandExecutionLog[1].Message)
}