drpmma commented on code in PR #6188:
URL: https://github.com/apache/rocketmq/pull/6188#discussion_r1155613556
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java:
##########
@@ -337,8 +337,13 @@ private Runnable
buildProcessRequestHandler(ChannelHandlerContext ctx, RemotingC
log.error(cmd.toString());
if (!cmd.isOnewayRPC()) {
- response =
RemotingCommand.createResponseCommand(RemotingSysResponseCode.SYSTEM_ERROR,
- UtilAll.exceptionSimpleDesc(e));
+ if
(RemotingHelper.ACL_EXCEPTION.equals(e.getClass().getSimpleName())) {
Review Comment:
Would it be better to return the response in the processor with ACL failed
rather than deal with it in NettyRemotingAbstract.java?
The NettyRemotingAbstract should not care about ACL or specific error reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
