lyx2000 commented on code in PR #6522:
URL: https://github.com/apache/rocketmq/pull/6522#discussion_r1161314982
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/GrpcMessagingApplication.java:
##########
@@ -171,9 +172,10 @@ protected ProxyContext createContext() {
.setLocalAddress(getDefaultStringMetadataInfo(headers,
InterceptorConstants.LOCAL_ADDRESS))
.setRemoteAddress(getDefaultStringMetadataInfo(headers,
InterceptorConstants.REMOTE_ADDRESS))
.setClientID(getDefaultStringMetadataInfo(headers,
InterceptorConstants.CLIENT_ID))
+ .setProtocolType(ChannelProtocolType.GRPC_V2.getName())
.setLanguage(getDefaultStringMetadataInfo(headers,
InterceptorConstants.LANGUAGE))
.setClientVersion(getDefaultStringMetadataInfo(headers,
InterceptorConstants.CLIENT_VERSION))
- .setAction(getDefaultStringMetadataInfo(headers,
InterceptorConstants.RPC_NAME));
+ .setAction(getDefaultStringMetadataInfo(headers,
InterceptorConstants.SIMPLE_RPC_NAME));
Review Comment:
For the class `ProxyContext`, I have already added the `PROTOCOL_TYPE`
attribute to record the protocol. In order to align with the proxyContext of
remoteing, there is no need to repeat protocol prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
