RongtongJin commented on PR #6417:
URL: https://github.com/apache/rocketmq/pull/6417#issuecomment-1501620011

   > Hi @RongtongJin , I created an example for the DefaultLitePullConsumer. To 
use this example testing the Async pull, we need to change the line 680 in 
DefaultLitePullConsumerImpl into `PullTaskImpl pullTask = new 
PullTaskImpl(messageQueue, CommunicationMode.ASYNC);`
   > 
   > Here is the conclusion of its performance.
   > 
   > 1. When the message is consumed **successfully**,
   >    Different queues will run in concurrently, while the message in the 
same queue will be consumed orderly. We can check the QueueId and QueueOffset 
of messageExts to confirm it. I think this meets our expectations.
   > 2. When the message is consumed **unsuccessfully**,
   >    The exception will call the onException() in the pullCallback we 
defined in line 989. The pullDelayTimeMills will be changed according to the 
type of the exception. It will be set as the delay of the 
scheduledThreadPoolExecutor.
   > 
   > That's all of the test. I would appreciate if you have any better idea of 
the test and I'm happy to do anything I can to improve it.
   
   
   
   > Hi @RongtongJin , I created an example for the DefaultLitePullConsumer. To 
use this example testing the Async pull, we need to change the line 680 in 
DefaultLitePullConsumerImpl into `PullTaskImpl pullTask = new 
PullTaskImpl(messageQueue, CommunicationMode.ASYNC);`
   > 
   > Here is the conclusion of its performance.
   > 
   > 1. When the message is consumed **successfully**,
   >    Different queues will run in concurrently, while the message in the 
same queue will be consumed orderly. We can check the QueueId and QueueOffset 
of messageExts to confirm it. I think this meets our expectations.
   > 2. When the message is consumed **unsuccessfully**,
   >    The exception will call the onException() in the pullCallback we 
defined in line 989. The pullDelayTimeMills will be changed according to the 
type of the exception. It will be set as the delay of the 
scheduledThreadPoolExecutor.
   > 
   > That's all of the test. I would appreciate if you have any better idea of 
the test and I'm happy to do anything I can to improve it.
   
   Firstly, testing needs to verify whether it can solve the problem described 
in the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to