lizhanhui commented on PR #6583: URL: https://github.com/apache/rocketmq/pull/6583#issuecomment-1505108339
> > Should any compatibility issues be taken into consideration? > > Json is a general-purpose text protocol, i found there has used gson to check the compatibility in some unit test. So i think that is no compatibility problem if the unit test can be passed > So i think that is no compatibility problem if the unit test can be passed The unit test only covers a very small part of the usage, aka, having namesrv generate valid JSON when answering route of topic query. Actually, there are a few places, for example, consume-offset incompatible JSON is used since key of the entry is not string. Prior issues have to be fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
