RongtongJin commented on PR #6571: URL: https://github.com/apache/rocketmq/pull/6571#issuecomment-1505116162
> This fix is too complex and less performant. How about this way: Before entering the critical region, validate and serialize the messages, with consume queue offset filled with place holders. In the critical region, allocate offsets as before and replace place-holders with them. This way, critical region is minimized and CPU-intensive serialization can be parallel at the same time. Hi @lizhanhui, my fix do not change the logic of entering the critical region, but the operation of validate and serialize the messages can indeed be moved outside of topicQueueLock, I will try it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
