fuyou001 commented on code in PR #6571:
URL: https://github.com/apache/rocketmq/pull/6571#discussion_r1164893592
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -2039,11 +2039,21 @@ public boolean isSyncMaster() {
}
@Override
- public void assignOffset(MessageExtBrokerInner msg, short messageNum) {
+ public void assignOffset(MessageExtBrokerInner msg) {
final int tranType =
MessageSysFlag.getTransactionValue(msg.getSysFlag());
if (tranType == MessageSysFlag.TRANSACTION_NOT_TYPE || tranType ==
MessageSysFlag.TRANSACTION_COMMIT_TYPE) {
Review Comment:
refactor it as a method for determining message types maybe better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
