[GitHub] [rocketmq] superhx commented on a diff in pull request #6590: (fix): logback config path seperator and brokerLogDir default value m…

Mon, 17 Apr 2023 00:48:32 -0700 


superhx commented on code in PR #6590:
URL: https://github.com/apache/rocketmq/pull/6590#discussion_r1168310070


##########
proxy/src/main/resources/rmq.proxy.logback.xml:
##########
@@ -229,10 +229,10 @@
 
     <appender name="RocketmqRebalanceLockAppender_inner"
               class="ch.qos.logback.core.rolling.RollingFileAppender">
-        <file>${user.home}/logs/rocketmqlogs/${brokerLogDir}/lock.log</file>
+        
<file>${user.home}${file.separator}logs${file.separator}rocketmqlogs${file.separator}${brokerLogDir:-${file.separator}}${file.separator}lock.log</file>

Review Comment:
   Use launch cmd in RocketMQ Quick Start
   nohup sh bin/mqnamesrv &
   nohup sh bin/mqbroker -n localhost:9876 --enable-proxy &
   
   In my local machine Mac:
   
![image](https://user-images.githubusercontent.com/5719209/232413538-2e806492-490e-4ff1-9857-82d08d1ba23b.png)
   
   In Linux:
   
![image](https://user-images.githubusercontent.com/5719209/232419186-946bedec-ca2b-4695-a120-9d1b9547acad.png)
   
   
   Don't have Windows machine
   
   
   PS. the proxy logback config path format is the same as 
rmq.broker.logback.xml



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to