Oliverwqcwrw commented on code in PR #6602:
URL: https://github.com/apache/rocketmq/pull/6602#discussion_r1173214861


##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -922,13 +922,9 @@ private void initialTransaction() {
     }
 
     private void initialAcl() {
-        if (!this.brokerConfig.isAclEnable()) {
-            LOG.info("The broker dose not enable acl");
-            return;
-        }
-
         List<AccessValidator> accessValidators = 
ServiceProvider.load(AccessValidator.class);
-        if (accessValidators.isEmpty()) {
+
+        if (accessValidators.isEmpty() && this.brokerConfig.isAclEnable()) {

Review Comment:
   If the acl is turned off before starting the broker and the acl is turned on 
after starting the broker and the default validator is still empty, it is 
recommended that the initial add the default validator directly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to