zk-drizzle commented on code in PR #6507:
URL: https://github.com/apache/rocketmq/pull/6507#discussion_r1173232587
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -1686,6 +1690,16 @@ public boolean checkInDiskByCommitOffset(long offsetPy) {
return offsetPy >= commitLog.getMinOffset();
}
+ /**
+ * The ratio val is estimated by the experiment and experience
+ * so that the result is not high accurate for different business
+ * @return
+ */
+ public boolean checkInColdAreaByCommitOffset(long offsetPy, long
maxOffsetPy) {
Review Comment:
This method mainily helps us distinguish between logical cold data and not.
Sometimes it can prevent normal consumers from being cold controlled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]